Open r0mflip opened 4 years ago
Can you add an option to filter out tags that are just version numbers with no information.
Can be done programatically. Will remove all "empty" tags then.
Can you add the command you ran to the package.json or readme as documentation ?
I've updated the command in readme. If to be added as an npm script should we use prepublishOnly
?
@r0mflip i've rebased this, and would still like to see it land. Have you had time to make some of the changes we discussed above?
also, it'd be nice if the github token was read from the env when present (GITHUB_TOKEN or GH_TOKEN), and if -r
was optional (since it can read from package.json)
Merging #521 (afc4010) into master (8e60dcb) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 19 19
Lines 766 766
Branches 146 146
=======================================
Hits 568 568
Misses 198 198
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8e60dcb...afc4010. Read the comment docs.
Hi @ljharb. Apologies for all the delay. Got a day job and was unable to work on OSS, and worse my personal laptop died. Inquiring on my end to see if my corp laptop can be used for this, or maybe I'll grab my brother's machine.
Will try to get it done during weekend.
No worries, thanks :-) keep me posted.
Hi Jordan, might not be able to work on this. Don't have enough bandwidth to work on this :(
@r0mflip thanks for following up; we'll leave this open in case someone else wants to pick it up (if someone does, please post a link to a branch and i'll pull it into this PR)
Based on #517
I don't think this might be the expected result, but It's something that we can get from GitHub API
Used https://github.com/r0mflip/logtag to generate changelog.