tape-testing / tape

tap-producing test harness for node and browsers
MIT License
5.77k stars 307 forks source link

left/right instead of expected/actual in test output #526

Closed ghost closed 4 years ago

ghost commented 4 years ago

For equality comparisons, rust's test runner uses "left" and "right". I like this better than "expected" and "actual" because it takes me a moment to remember which argument is which. I'm not sure what t.ok() and t.notOk() should report.

ljharb commented 4 years ago

Would you think that this would be a breaking change, or that nobody would be depending on the wording in the output?

ghost commented 4 years ago

I didn't find anything right away but I think some of the pretty output parser modules expect to find "expected" and "actual" in the yaml block so this would be a breaking change.

ljharb commented 4 years ago

Is that particularly worth it? It seems like a pretty minimal improvement.

ghost commented 4 years ago

ok closing then

ljharb commented 4 years ago

We could certainly still consider it if we were already doing a v6, but v5 just came out and i don't expect any breaking changes for awhile.