Closed vweevers closed 2 years ago
Merging #571 (d487add) into master (e41763f) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 4 4
Lines 627 627
Branches 145 145
=======================================
Hits 605 605
Misses 22 22
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e41763f...d487add. Read the comment docs.
@vweevers and with this, do all the windows tests pass? or are there still some failures left.
All but one (test/async-await.js
):
And there's some problem with nyc
:
Alternative to #559.
This is required on Windows if the argument passed to
import()
is an absolute path. Without ittape test.js
fails if test.js is ESM.Covered by existing tests:
node test/import.js
fails without this (as well as some other tests but those seem less relevant to the issue at hand).See https://github.com/nodejs/node/commit/a0846326dd42bf4ec2f91df9cade762283567511