Closed Joris-van-der-Wel closed 7 months ago
New dependencies detected. Learn more about Socket for GitHub ↗︎
Packages | Version | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|---|
nyc | 10.3.2 | eval, environment | +1 |
23.6 MB | bcoe |
I have a new version of these commits without any dependency update. They are on a different branch.
How would you prefer to receive these new changes? Force push? New PR? Extra commit?
Force push to this branch would be great :-) thanks!
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4640a91
) 96.76% compared to head (fc33439
) 96.76%.:exclamation: Current head fc33439 differs from pull request most recent head bcf6ce7. Consider uploading reports for the commit bcf6ce7 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a follow up of #183 which involved a similar fix for a much older version (9 years ago) of this library. I noted 4 years ago that the stack trace parsing on windows had already been fixed by someone else.
However I just discovered that the issue has cropped up again, which this PR attempts to fix. Luckily this time the existing tests already check for this issue, however the tests must be ran on windows. This uncovered more issues because a lot of tests were broken on windows.
Some tests were attempting to spawn
bin/tape
, instead ofnode bin/tape
. This does not work on my windows machine.The failing tests uncovered that the
--ignore
and--ignore-pattern
options do not work properly on windows. This was because the old version of glob uses forward slashes on windows, while dotignore expects backslashes.It was not possible to run the tests using
npm test
. This was because of a bug in the old versions ofnyc
, and also because single quotes were used in the run script.Before:
After:
The individual commits in this PR contain more details.