tapexyz / tape

an open media-sharing platform.
https://tape.xyz
GNU Affero General Public License v3.0
4.45k stars 315 forks source link

Requesting to add 'diversehq' appId to ALLOWED_APP_IDS for DiverseHQ #831

Closed RathodDeven closed 1 year ago

RathodDeven commented 1 year ago

Describe the feature you'd like to request

Hi, Sasi! I am unsure if any requirements must be fulfilled to be eligible to be added to the ALLOWED_APP_IDS. If there are any please let me know, else requesting to add the 'diversehq' appId to the ALLOWED_APP_IDS. Thanks 🙌.

Here is a metadata link : https://gateway.ipfscdn.io/ipfs/QmTRv7KRixYrHqrHaR38vg7fqn79T8HmxwUqm6EYYaLBxL/

sasicodes commented 1 year ago

durationInSeconds is missing in attributes 🙇🏻

RathodDeven commented 1 year ago

durationInSeconds is missing in attributes 🙇🏻

Hey, thanks for that just deployed changes for this, and now video publications will have durationInSeconds in attributes, check this metadata URL https://gateway.ipfscdn.io/ipfs/QmeeUjWkmTHpB3Ga6ESraGDKJC2q39LvfucRJifPna2S65/ Also here is the post link: https://diversehq.xyz/p/0x0161ba-0x0146-DA-f461ae71

Thank you and if there is anything else please let me know. 🙌🏻

sasicodes commented 1 year ago

is it possible to add a thumbnail for the video, in cover or image key?

RathodDeven commented 1 year ago

is it possible to add a thumbnail for the video, in cover or image key?

Yes, will be deploying ability to choose thumbnail soon.

RathodDeven commented 1 year ago

is it possible to add a thumbnail for the video, in cover or image key?

Hey, just deployed the required changes, now there will be a thumbnail image in image key...

Here is the example of metadata link : https://gateway.ipfscdn.io/ipfs/QmTRv7KRixYrHqrHaR38vg7fqn79T8HmxwUqm6EYYaLBxL/

If there is still anything else please let me know

sasicodes commented 1 year ago

looks good. you can add cover in the media object itself to indicate that's cover of the media is attached 🙇🏻

  "media": [
    {
      "item": "ipfs://bafybeidvy5rnnsx5sg2hdxivgrbmp5r2owdu2zxdpg7pb4nwwb7t3xozyi",
      "type": "video/mp4",
      "cover": "ipfs://bafybeici3z735c7od2augh7nlmaugq3ruzu4ytlqntjcb5dk2j4x4ixp3m"
    }
  ],

https://arweave.app/tx/jPX23KK8cq_Us0RMpqXcuZOoiZuksG5-9j4DmKKUPHg

RathodDeven commented 1 year ago

looks good. you can add cover in the media object itself to indicate that's cover of the media is attached 🙇🏻

  "media": [
    {
      "item": "ipfs://bafybeidvy5rnnsx5sg2hdxivgrbmp5r2owdu2zxdpg7pb4nwwb7t3xozyi",
      "type": "video/mp4",
      "cover": "ipfs://bafybeici3z735c7od2augh7nlmaugq3ruzu4ytlqntjcb5dk2j4x4ixp3m"
    }
  ],

https://arweave.app/tx/jPX23KK8cq_Us0RMpqXcuZOoiZuksG5-9j4DmKKUPHg

Aaha thanks, added this as well in the cover

https://gateway.ipfscdn.io/ipfs/QmTUr9TVouuSbaULu9pkCke7ViaBFonQsZykjMMupWKecP/

RathodDeven commented 1 year ago

Hey, any updates ..?

RathodDeven commented 1 year ago

Thanks a lot, Sassi!