search

tapio / rlutil

C and C++ utilities for cross-platform console roguelike game creation.
http://tapio.github.com/rlutil/
229 stars 42 forks source link

Defining min/max is a bad idea #27

Closed nabijaczleweli closed 8 years ago

nabijaczleweli commented 8 years ago

Especially since it's done after everything else, not bringing anything to the table

nabijaczleweli commented 8 years ago

Shall I submit a PR?

Zorgatone commented 8 years ago

What min/max do you mean? Terminal size?

nabijaczleweli commented 8 years ago

No, this

tapio commented 8 years ago

I think those are a left over from days past when I though to put various utilities here instead of just console I/O. I've been lately thinking of removing them too.

Zorgatone commented 8 years ago

I don't see whether this could any good or bad at all.

I don't see the point in having or remove that at all... It's just some pointless piece of code IMHO

nabijaczleweli commented 8 years ago

If it's pointless, it shall be purged!

(also, it's not pointless; it's actually damaging)

nabijaczleweli commented 8 years ago

@tapio You know merging that PR would've autoclosed this issue as well?

tapio commented 8 years ago

You know merging that PR would've autoclosed this issue as well?

That's what I did, which you can see in that message: "tapio closed this in #28 an hour ago"

Zorgatone commented 8 years ago

Drunk @nabijaczleweli 😂