search

tapios / risk-networks

Code for risk networks: a blend of compartmental models, graphs, data assimilation and semi-supervised learning
Other
2 stars 2 forks source link

resolving several issues #125

Closed odunbar closed 4 years ago

odunbar commented 4 years ago

Resolves #124 Resolves #123 Resolves #116 Resolves #114 Resolves #20

Also the way the vertical lists look with 

function(`
arg1,
arg2,
arg3
)

looks weird on my editor, they are inconsistently positioned, especially where the final bracket goes, whereas function(arg1, ____arg2, ____arg3)

looks clean, so I will continue with this notation if that's ok.

glwagner commented 4 years ago

I just linked the issues. It seems you have to write "Resolves X" for every issue you would like to resolve with this PR.

As for the alignment issues --- the problem may be tabs. Everyone should make sure that their editors do not use tabs. Instead, we should configure our editors to write 4 spaces when "tab" is pressed. This is relatively important since it can lead to lots of formatting issues, which matter in python.

glwagner commented 4 years ago

Tabs were previously used in the code and caused issues with formatting.

odunbar commented 4 years ago

I can use the style you recommend here

odunbar commented 4 years ago

I've resolved the style questions and removed the print statements. Will merge.