tapios / risk-networks

Code for risk networks: a blend of compartmental models, graphs, data assimilation and semi-supervised learning
Other
2 stars 2 forks source link

`update_beta_rates` is updating both transmission rate and average contact rates #25

Closed glwagner closed 4 years ago

glwagner commented 4 years ago

This function

https://github.com/dburov190/risk-networks/blob/00c5ab689f8cd4bb8b1fe286c49c681390af327d/epiforecast/kinetic_model_simulator.py#L235

may be misleading. It looks like beta_dict is not a dictionary of transmission rates, but rather a dictionary of the conflated quantity

beta * w_ij

Is this correct?

In other words, the transmission rate (which we currently assume is constant across the network, and is a parameter that needs to be inferred in data assimilation) is multiplied by the average contact rate. I think it is incorrect to call this product of terms "beta".

cc @odunbar @tapios @dburov190 @lubo93

glwagner commented 4 years ago

Resolved by #44