search

tapios / risk-networks

Code for risk networks: a blend of compartmental models, graphs, data assimilation and semi-supervised learning
Other
2 stars 2 forks source link

This average_wjis produces NANs with some random seeds... #27

Closed odunbar closed 4 years ago

odunbar commented 4 years ago

https://github.com/dburov190/risk-networks/blob/ed1d9a577ae60d3a9c1618856cd472057057e122/epiforecast/temporal_adjacency.py#L144

odunbar commented 4 years ago

run generate_static_contact_networks_orad.py and you get overflows in divide

dburov190 commented 4 years ago

Fixed by #37

glwagner commented 4 years ago

It's not a big deal (and optimism is good), but FYI --- rather than closing this issue prior to merging the pull request that fixes it, we should write "Resolves #XX" in the pull request. Writing this in the pull request means the issue will be closed automatically when the pull request is merged. Right now, this issue is technically not resolved because the pull request isn't yet merged.

dburov190 commented 4 years ago

There were three identical issues, so I closed two of them and left only one open. It is a bad practice to have more than one github "issue" for one real issue; this creates additional confusion.

glwagner commented 4 years ago

When you close an issue, please state the reason it is being closed.