search

tapios / risk-networks

Code for risk networks: a blend of compartmental models, graphs, data assimilation and semi-supervised learning
Other
2 stars 2 forks source link

Two classes "Observations" #98

Closed dburov190 closed 4 years ago

dburov190 commented 4 years ago

There are currently two classes named Observations defined in:

In the latest simulation examples (like the ones with idealized NYC data) it seems that the latter is used; can we get rid of the former? Or merge? or rename? If we need both, what is the purpose of each one of them?

agarbuno commented 4 years ago

My take is that it's safe to remove the observations.py. @odunbar, do you agree ?

odunbar commented 4 years ago

Yup! sorry I was going to do that in our PR but forgot - will do now