tapis-project / authenticator

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

fix: layout & text of authorize & login forms #49

Closed wesleyboar closed 1 year ago

wesleyboar commented 1 year ago

Overview

The "TTL" (Time To Live) value input for the Authorize form was too large and butting up against "Approve" checkbox. This fixes that, but reveals a Core-Styles bug, so updates to patch to fix that.

Important There are two designs for this. I review with designers and will request leadership approval.

Related

Changes

Testing

  1. Login such that you will be asked to approve token.
  2. Verify checkbox field layout is not bumping against "Approve" checkbox.
  3. Verify default value for TTL is shown as placeholder.

Warning My testing has been in situ on dev server.

HTML (for Design A) ```html
```

UI

There are two designs:

pro & con code
A clear, but requires WMA set client_display_name #49 (this)
B requires no WMA effort, but not clear to user wesleyboar#1
sans TTL field with TTL field
A Connect Connect (with TTL)
B Authorize Authorize (with TTL)
accessibility
Auth - TTL A11y
Archive ### As of 75c53a4 | with TTL field | sans TTL field | | - | - | | ![with ttl field](https://github.com/tapis-project/authenticator/assets/62723358/9939100d-f255-4707-ada7-5533562dacab) | ![sans ttl field](https://github.com/tapis-project/authenticator/assets/62723358/637911c8-7362-4042-9ccf-e8bdd2f7d02f) | | accessibility | | - | | ![a11y](https://github.com/tapis-project/authenticator/assets/62723358/024f02cc-7d17-4a2c-96c0-fc364a1f2538) | ### As of 562054b | before (in situ test) | after (in situ test) | | - | - | | before | after | | accessibility | | - | | a11y |