search

tapis-project / authenticator

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

fix: makefile error with docker compose v2 #64

Closed wesleyboar closed 9 months ago

wesleyboar commented 9 months ago

Overview

Prevent error during "First Time Setup" when using Docker Compose v2.

Warning 2023-10-09 17:30 PM. This should be reverted. See comment.

Changes

Testing

  1. Prune docker containers and volumes.
  2. export API_NAME=authenticator
  3. make init_dbs
  4. Verify no Error: No such container:path: authenticator_postgres_1:/.

Notes

Note In Compose V1, an underscore (_) was used as the word separator. In Compose V2, a hyphen (-) is used as the word separator. Source. So, the Makefile should reference authenticator-postgres-1.

Important From July 2023 Compose V1 stopped receiving updates. It's also no longer available in new releases of Docker Desktop.

Compose V2 is included with all currently supported versions of Docker Desktop. For more information, see Migrate to Compose V2.

Docker's documentation refers to and describes Compose V2 functionality.

— https://docs.docker.com/compose/release-notes/ (2023-10-09)

wesleyboar commented 9 months ago

There was discussion post-merge. Some devs use Docker Compose v2 and have no issue. Also, the CI/CD pipelines are not ready for the change. There may be insight on Stack Overflow.