search

tapis-project / authenticator

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

feat: GH-79: lock fieldsets and buttons on form submit #83

Closed wesleyboar closed 1 month ago

wesleyboar commented 1 month ago

Overview

When a form is submitted, disable its fieldsets (thus fields of each fieldset) and buttons.

Related

Changes

Testing

  1. Open /v3/oauth2/webapp.
  2. Submit form.
  3. Verify fields become disabled.
  4. Verify button becomes disabled.

[!WARNING] I have not tested MFA.

UI

✅ 3f035e2 https://github.com/user-attachments/assets/7d48032f-b803-4354-8fb2-b819f9d6946b ✐ When fields are `readonly`, user can select and focus, but **not** type. ✐ When field is not in focus, it has no border.
❌ c481f78 ⨂ Uses `disabled` which prevents submission of data. | login | mfa | | - | - | | GH-79 login | ❓ | https://github.com/user-attachments/assets/f2c19f79-570a-48f6-b58c-225a8977bd03
wesleyboar commented 1 month ago

[!NOTE] Disabling fields (via disabled) would cause the form data to not be submitted. That's why I used readonly.