issues
search
tapis-project
/
authenticator
BSD 3-Clause "New" or "Revised" License
1
stars
3
forks
source link
fix: mfa misc round 2 (e.g. disable submit button)
#94
Closed
wesleyboar
closed
1 month ago
wesleyboar
commented
1 month ago
[!IMPORTANT] Accidentally closed. See #95 instead.
Archived
## Overview Misc. Fixes, Round 2 ## Changes / Testing / UI
1. On submit,
truly
disable button. (f0dcfae, 6a2cae0, 085a8cb, 085a8cb)
0. (optional) In console, pause form on submit:
`document.querySelector('form').addEventListener('submit', (event) => { event.preventDefault(); });`.
1. Submit form. 2. Hover cursor over submit button. 3. Verify pointer is **not** a pointing hand.\ (Verify button has attribute `disabled`.)
2. Do not remember failed MFA tokens. (b3540e1)
1. Submit MFA form with wrong token. 2. After submit fails, focus on MFA field. 3. Verify previous (failed) token is not available as autofill. https://github.com/user-attachments/assets/d58d29c2-e132-4001-a55d-38bcdeeddff6
3. Auto-focus "Username" and "Token" fields. (56cf276)
1. On Login form, notice "Username" field, auto-receives focus. 2. On MFA form, notice "Token" field auto-receives focus. https://github.com/user-attachments/assets/dcef5f8e-ffc2-4228-a0f6-78ca354b87eb https://github.com/user-attachments/assets/960dd7b8-2646-41d4-a9f0-c1088dfe6a3d
Archived
## Overview Misc. Fixes, Round 2 ## Changes / Testing / UI1. On submit, truly disable button. (f0dcfae, 6a2cae0, 085a8cb, 085a8cb)
0. (optional) In console, pause form on submit: `document.querySelector('form').addEventListener('submit', (event) => { event.preventDefault(); });`. 1. Submit form. 2. Hover cursor over submit button. 3. Verify pointer is **not** a pointing hand.\ (Verify button has attribute `disabled`.)2. Do not remember failed MFA tokens. (b3540e1)
1. Submit MFA form with wrong token. 2. After submit fails, focus on MFA field. 3. Verify previous (failed) token is not available as autofill. https://github.com/user-attachments/assets/d58d29c2-e132-4001-a55d-38bcdeeddff63. Auto-focus "Username" and "Token" fields. (56cf276)
1. On Login form, notice "Username" field, auto-receives focus. 2. On MFA form, notice "Token" field auto-receives focus. https://github.com/user-attachments/assets/dcef5f8e-ffc2-4228-a0f6-78ca354b87eb https://github.com/user-attachments/assets/960dd7b8-2646-41d4-a9f0-c1088dfe6a3d