Closed command-c closed 3 months ago
Hi @command-c: Sorry for the delay. I somehow missed the notification of your PR.
I pulled down the code and started to review. If I understand it correctly, I believe there are some things that need to change. The main thing is that it seems as though this version removes support for using Scaphadre as a backend and only supports JTOP, e.g.,
elif BACKEND == "scaphadre": raise NotImplementedError
We should support both Scaphandre and JTOP since we want to support multiple platforms (including ones which are incompatible with JTOP). We can have a deeper discussion on the ICICLE slack.
Hi @joestubbs , yes I can add scaphadre support back. Previously I removed it since I don't have compatible device on my hand. I expect could do it by this week.
I tested power measurement plugin in my jetson nano device. And added auto backend switch between jetson series and other linux. For jetson will use jtop for others will invoke scaphandre.
Thanks, @command-c , I have merge these into main manually.
Main change happen in ./external_plugins/power_measuring_plugin folder the ./build_and_run_sample.sh script used to perform the entire native docker build for Orin device. the ./command_hint.sh just a reminder for myself.
"camera-traps/releases/0.3.3_power_test" just used for testing power plugin. Can be ignored
I tested the entire release on Orin. The log out put is: camera-traps/releases/0.3.3/compose output from Orin.log Not sure whether it looks good for other plugins.
PS: A little question: Are we pushing for 0.3.3 or 0.3.4?