search

tapjs / foreground-child

Run a child as if it's the foreground process. Give it stdio. Exit when it exits.
http://tapjs.github.io/foreground-child/
ISC License
39 stars 14 forks source link

Add timeout to fix race condition in tests #11

Closed addaleax closed 6 years ago

addaleax commented 8 years ago

Add a timeout to the process.kill(process.pid, ...) test cases so that the process is always around long enough to receive the signal.

Example failure: https://travis-ci.org/tapjs/foreground-child/jobs/133638718

I couldn’t reproduce these problems locally, and I find it slightly weird that some sort of exit takes place before process.kill succeeds, but this does seem to fix the CI failures…

addaleax commented 6 years ago

ping @isaacs