search

tapjs / foreground-child

Run a child as if it's the foreground process. Give it stdio. Exit when it exits.
http://tapjs.github.io/foreground-child/
ISC License
39 stars 14 forks source link

Use fd numbers instead of 'inherit' for Node v0.10 compatibility #12

Closed addaleax closed 8 years ago

addaleax commented 8 years ago

Use 0, 1, 2 for specifiying child process stdio instead of 'inherit', since Node v0.10 does not support the latter.

Example failure: https://github.com/bcoe/nyc/issues/275

Sorry I broke this, this time I checked v0.10 manually.

/cc @bcoe @isaacs

isaacs commented 8 years ago

Oops, sorry I should've caught that in review. Landed and published on npm.