tapjs / foreground-child

Run a child as if it's the foreground process. Give it stdio. Exit when it exits.

http://tapjs.github.io/foreground-child/

ISC License

40 stars 14 forks source link

refactor: Accept parent process as argument to `proxySignals` #26

Closed demurgos closed 5 years ago

demurgos commented 6 years ago

Why

foregroundChild is currently hard-coded to only support forwarding with the root process. To support a general proxy function between any two objects behaving like processes, we can begin by refactoring the internals to be more parametrized.

What

Document proxySignals and update its signature to accept the parent process.

demurgos commented 6 years ago

The CI failure seems to be an Appveyor issue (issue in their npm package). Fixed in https://github.com/tapjs/foreground-child/pull/24.

demurgos commented 5 years ago

@bcoe I rebased my changes and applied @ProfNandaa's suggestion (return the function immediately)

bcoe commented 5 years ago

do we still want to land some of the work in foreground-child and spawn-wrap; haven't heard from you in a bit @demurgos.

demurgos commented 5 years ago

Hi, I had less time at the beginning of the year and was absent. I am currently checking all the repos I watch and open issues. I also joind the node-tooling Slack and should be there more regularly.

Regarding this specific issue, I'd still like it to land. It's content is still good and self-contained.

I no longer use spawn-wrap but I'd be willing to help merging my fixes if there is interest for istanbul.