search

tapjs / foreground-child

Run a child as if it's the foreground process. Give it stdio. Exit when it exits.
http://tapjs.github.io/foreground-child/
ISC License
39 stars 14 forks source link

No longer compatible with Node < 14.16 since v3.x, update engines.node #56

Open webketje opened 5 months ago

webketje commented 5 months ago

Since the use of the node: import prefix at https://github.com/tapjs/foreground-child/blob/v3.0.0/src/all-signals.ts#L1 this library has become incompatible with Node.js < 16. Found this through using c8 in a failed automated test run at https://github.com/metalsmith/metalsmith/actions/runs/7854693798/job/21435716699.

Error: Cannot find module 'node:constants'

Even though npm view c8@latest engines.node returns >=14.14.0 Please revert to importing from constants OR update engines.node to >=16

webketje commented 4 months ago

Please update engines.node to >=14.18.0, see linked issue for analysis