Closed jaridmargolin closed 7 years ago
Regarding tests... All tests on my machine fail without this patch because the path at which I am working on this PR contains a (
character. With the patch added, I see nothing but green :)
If executed in a different cwd, on CI for instance, this patch will not be properly tested. If I can get buy-in that this is a valid approach to fixing the problem, and I am not overlooking any obvious shortcomings, I will add a more robust test to guarantee this patch is operating as intended.
@jamestalmage @isaacs
Thanks!
PR to open discussion regarding #23, Fail to parseLine when path contains '('.
Example:
This may be a naive approach, but simply changing the matching pattern for location to not negate
)
appears to fix the issue while not breaking any of the existing tests. However, negating the character in the first place appears to have been a very intentional choice. I am assuming there is a missing testcase for this requirement?