Filter out all Node.js internals - Githubissues

tapjs / stack-utils

Captures and cleans stack traces.

https://www.npmjs.com/package/stack-utils

MIT License

190 stars 35 forks source link

Filter out all Node.js internals #25

Closed isaacs closed 7 years ago

isaacs commented 7 years ago

This filters out all internals from the currently running version of Node.js by looking at the actual list of native modules in the current process.

Adds a way to hard-code the list of natives, for testing across different versions of Node with different native modules.

Fix #14

r? @jamestalmage @sindresorhus

coveralls commented 7 years ago

Coverage increased (+0.04%) to 98.667% when pulling f2fbbc1be4de3f9ed77d750d4d3cb168f357258a on filter-all-internals into bf7bf375c64c28b42b6c74034ac78b9e2a55dd45 on master.

coveralls commented 7 years ago

Coverage increased (+0.04%) to 98.667% when pulling f2fbbc1be4de3f9ed77d750d4d3cb168f357258a on filter-all-internals into bf7bf375c64c28b42b6c74034ac78b9e2a55dd45 on master.

coveralls commented 7 years ago

Coverage increased (+0.04%) to 98.667% when pulling f2fbbc1be4de3f9ed77d750d4d3cb168f357258a on filter-all-internals into bf7bf375c64c28b42b6c74034ac78b9e2a55dd45 on master.

isaacs commented 7 years ago

Added a second patch that also fixes #23. Similar to #24, but with a non-greedy regexp so it doesn't end up trying to swallow past the numbers and onto the closing ) at the end of the line. Added a test as well.

coveralls commented 7 years ago

Coverage increased (+0.04%) to 98.667% when pulling 966e05d7626a8dc126eec19b499abee6ea32c664 on filter-all-internals into bf7bf375c64c28b42b6c74034ac78b9e2a55dd45 on master.

coveralls commented 7 years ago

Coverage increased (+0.07%) to 98.701% when pulling 30a0f29d5ac4ca79750a525433cdb6f2aba70f46 on filter-all-internals into bf7bf375c64c28b42b6c74034ac78b9e2a55dd45 on master.

isaacs commented 7 years ago

Landed on 1.0.0