search

tapjs / tap-parser

parse the test anything protocol
121 stars 35 forks source link

Passed tests #51

Closed epoberezkin closed 7 years ago

epoberezkin commented 7 years ago

Failed tests are included in the parsed output in 'failures' field.

Can we add 'successes' field to include all passed tests with their objects?

isaacs commented 7 years ago

Why not just listen to the assert event? What's the use case for this?

epoberezkin commented 7 years ago

Why not just listen to the assert event?

It just seems easier to process in callback, once all results are parsed. It's possible for failures but not for successes

What's the use case for this?

Whenever test results are used to maintain some state. In my case, failure creates an issue, success closes an issue (in tap-github-issues package)

isaacs commented 7 years ago

@epoberezkin Thanks! That does make sense. You could definitely do this by acting on each event as it comes in, but you'd probably have to switch from a yield-based system to a async/await type deal. I can see how it's easier to just wait for it all to be done in this case.

isaacs commented 7 years ago

Landed on latest release. Thanks!

epoberezkin commented 7 years ago

@isaacs thank you!

ORESoftware commented 7 years ago

mucho bueno 👍