fix: #11, basic subpath import support

tapjs / tsimp

https://tapjs.github.io/tsimp/

Other

508 stars 12 forks source link

fix: #11, basic subpath import support #23

Closed ajvincent closed 4 months ago

ajvincent commented 4 months ago

First-time contributor here. Very rudimentary, minimally tested support for subpath imports.

ajvincent commented 4 months ago

I think I made a mistake on this, being unaware of the conditional exports support in the subpath imports feature.

ajvincent commented 4 months ago

... and on top of that, it doesn't work. I locally patched it and got the same "cannot find module".

Cannot find module '/home/ajvincent/membranes/es-membrane/utilities/source/BuildPromise.js' imported from /home/ajvincent/membranes/es-membrane/utilities/checkUtilities.ts

BuildPromise.ts is in the right place. It's just the extension mismatch.

ajvincent commented 4 months ago

sigh my PR did absolutely nothing. I got the exact same error message before my "fix". Apologies for all the noise.