taplytics / Taplytics-Android-SDK

Taplytics Android SDK
http://taplytics.com
19 stars 9 forks source link

Upgrade com.android.support dependencies to newer AndroidX variants #81

Closed erawhctim closed 2 years ago

erawhctim commented 3 years ago

In an attempt to disable the AndroidX Jetifier, we noticed that the Taplytics SDK still depends on support library dependencies. (detected via this gradle plugin).

Here's the output returned:

Scanning com.taplytics.sdk:taplytics:2.10.3
 Absoulute path: ...
 Graphs to this dependency:
 +---com.taplytics.sdk:taplytics:2.10.3
 Issues found:
 * com/taplytics/gnu$aardvark.class -> android/support/v7/widget/RecyclerView
 * com/taplytics/kudu.class -> android/support/v4/view/ViewPager
 * com/taplytics/kudu.class -> android/support/v4/view/PagerAdapter
 * com/taplytics/kudu.class -> android/support/v4/app/Fragment
 * com/taplytics/gnu.class -> android/support/v4/app/FragmentManager$OnBackStackChangedListener
 * com/taplytics/gnu.class -> android/support/v4/app/FragmentManager
 * com/taplytics/eland.class -> android/support/v7/widget/RecyclerView$RecyclerListener
 * com/taplytics/eland.class -> android/support/v7/widget/RecyclerView
 * com/taplytics/eland.class -> android/support/v7/widget/RecyclerView$ViewHolder
 * com/taplytics/echidna.class -> android/support/v7/widget/RecyclerView$OnScrollListener
 * com/taplytics/echidna.class -> android/support/v7/widget/RecyclerView
 * com/taplytics/echidna.class -> android/support/v7/widget/RecyclerView$LayoutManager
 * com/taplytics/echidna.class -> android/support/v7/widget/LinearLayoutManager
 * com/taplytics/grenadier.class -> android/support/v4/app/NotificationCompat$BigPictureStyle
 * com/taplytics/grenadier.class -> android/support/v4/app/NotificationCompat
 * com/taplytics/grenadier.class -> android/support/v4/app/NotificationCompat$BigTextStyle
 * com/taplytics/grenadier.class -> android/support/v4/app/NotificationCompat$Builder
 * com/taplytics/grenadier.class -> android/support/v4/app/NotificationCompat$Style
 * com/taplytics/kouprey.class -> android/support/v4/app/FragmentManager
 * com/taplytics/gnu$alligator.class -> android/support/v4/app/FragmentManager$OnBackStackChangedListener
 * com/taplytics/gnu$alligator.class -> android/support/v4/app/FragmentManager
 * com/taplytics/gnu$alligator.class -> android/support/v4/app/FragmentActivity
 * com/taplytics/gnu$alligator.class -> android/support/v4/app/Fragment
 * com/taplytics/gnu$alligator.class -> android/support/v4/app/DialogFragment
 * com/taplytics/crab.class -> android.support.v4.view.ViewPager
 * com/taplytics/crab.class -> android/support/v4/view/ViewPager
 * com/taplytics/crab.class -> android/support/v4/view/PagerAdapter
 * com/taplytics/crab.class -> android/support/v4/app/FragmentManager
 * com/taplytics/crab.class -> android/support/v4/app/Fragment
 * com/taplytics/crab.class -> android/support/v4/app/FragmentManager$OnBackStackChangedListener
 * com/taplytics/crab.class -> android/support/v4/app/FragmentPagerAdapter
 * com/taplytics/crab.class -> android/support/v4/app/FragmentStatePagerAdapter
 * com/taplytics/crab.class -> android/support/v7/widget/RecyclerView
 * com/taplytics/crab.class -> android/support/v7/widget/RecyclerView$OnScrollListener
 * com/taplytics/crab.class -> android/support/v7/widget/RecyclerView$RecyclerListener
 * com/taplytics/crab.class -> android/support/v7/widget/RecyclerView$Adapter
 * com/taplytics/crab.class -> android/support/v7/widget/RecyclerView$AdapterDataObserver
 * com/taplytics/crab.class -> android/support/v7/widget/RecyclerView$ViewHolder
 * com/taplytics/crab.class -> android/support/v7/widget/RecyclerView$LayoutManager
 * com/taplytics/crab.class -> android/support/v7/widget/LinearLayoutManager
 * com/taplytics/dog.class -> android/support/v7/widget/RecyclerView
 * com/taplytics/dog.class -> android/support/v7/widget/RecyclerView$OnScrollListener
 * com/taplytics/elephant.class -> android/support/v7/widget/RecyclerView$AdapterDataObserver
 * com/taplytics/elephant.class -> android/support/v7/widget/RecyclerView
 * com/taplytics/gnu$albatross.class -> android/support/v4/app/FragmentActivity
 * com/taplytics/gnu$albatross.class -> android/support/v4/app/FragmentManager
 * com/taplytics/gnu$albatross.class -> android/support/v4/app/Fragment
 * com/taplytics/gnu$albatross.class -> android/support/v7/widget/RecyclerView

Can these dependencies be updated and replaced with their respective AndroidX versions instead?

leslie-lau commented 3 years ago

Hi @erawhctim thanks for raising this issue, we'll have a look at the above and get back to you if we have any questions or updates.

leslie-lau commented 3 years ago

Hi @erawhctim our team has done an initial investigation on the request and provide the following response.

We have conducted an initial assessment and have decided not to proceed with this item in the near term and will opt to prioritize it for potentially later this year. Currently there are users who do leverage the support library dependencies so we'd be looking to have support for both the current dependency and the AndroidX versions.

We are always looking for ways to modernize our SDKs and we appreciate your suggestions. This has been added to our roadmap as a feature request.

KrestM commented 3 years ago

@leslie-lau do you have any updates about this issue? Is it still in the roadmap only? Thanks!

leslie-lau commented 3 years ago

Hi @KrestM no updates at this time, we're continuing to scope a solution that will create a seamless upgrade for all our of clients.

greenfodor commented 2 years ago

Hey @leslie-lau do you have any updates on when this could be released?

leslie-lau commented 2 years ago

Hi @greenfodor no updates at this time. We have not dropped this issue and still consider this an item that we'll need to tackle.

greenfodor commented 2 years ago

Hey @leslie-lau sorry to come to you again, but is there any way you could provide some estimations on when this could be resolved? Our build times are getting pretty big because of the fact that we cannot remove jetifier.

leslie-lau commented 2 years ago

Hi @greenfodor yes I can. Let me speak to the team and grab an updated timeline for you.

leslie-lau commented 2 years ago

Good news! Our team is currently working on this item and we expect it to be completed within a week or so.

VicV commented 2 years ago

Hey @erawhctim , @KrestM , and @greenfodor

https://github.com/taplytics/Taplytics-Android-SDK/releases/tag/3.0.0

We've updated the Taplytics Android SDK to AndroidX.