search

tapmodo / Jcrop

Jcrop - The Javascript Image Cropping Engine
https://jcrop.com
Other
4.31k stars 939 forks source link

Right-click behavior #133

Closed npat-efault closed 10 years ago

npat-efault commented 10 years ago

When right-clicking on a JCrop-targeted image I don't see the usual "save image as" browser menu. There does not seem to be a way to make JCrop not mess with the right-click on image behavior (at least there is no such mention in the docs).

claviska commented 10 years ago

That's because the cropper overlays the image. The image has to be the target element for that to show up.

On Jan 12, 2014, at 12:12 AM, Nick Patavalis notifications@github.com wrote:

When right-clicking on a JCrop-targeted image I don't see the usual "save image as" browser menu. There does not seem to be a way to make JCrop not mess with the right-click on image behavior (at least there is no such mention in the docs).

— Reply to this email directly or view it on GitHub.

npat-efault commented 10 years ago

Is there any workaround? That is: Is it possible to allow the user save an image that is the target of Jcrop?

claviska commented 10 years ago

Having the user right-click to save an image isn't very user-friendly anyway (there are many and varying options in browser context menus). I'm pretty sure this is a dead-end without some complicated hack that doesn't really belong in the plugin.

You'll probably be better off adding a download button/link instead. Much easier and more user-friendly :)

On Jan 12, 2014, at 5:48 AM, Nick Patavalis notifications@github.com wrote:

Is there any workaround? That is: Is it possible to allow the user save an image that is the target of Jcrop?

— Reply to this email directly or view it on GitHub.

npat-efault commented 10 years ago

That's how I did it anyway... I don't know if it's better this way (but at the least, it's a very acceptable workaround)

Thanks for the swift reply!

On Sun, Jan 12, 2014 at 5:59 PM, Cory LaViska notifications@github.comwrote:

Having the user right-click to save an image isn't very user-friendly anyway (there are many and varying options in browser context menus). I'm pretty sure this is a dead-end without some complicated hack that doesn't really belong in the plugin.

You'll probably be better off adding a download button/link instead. Much easier and more user-friendly :)

On Jan 12, 2014, at 5:48 AM, Nick Patavalis notifications@github.com wrote:

Is there any workaround? That is: Is it possible to allow the user save an image that is the target of Jcrop?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/tapmodo/Jcrop/issues/133#issuecomment-32125586 .

tapmodo commented 10 years ago

Jcrop just has too many elements that are over the image. There may be a way around this with CSS, but if the mouse events were passed to underlying elements it'd probably throw off the event handling of Jcrop. I'm going to close this issue as I can't think of an easy workaround.