search

tapmodo / Jcrop

Jcrop - The Javascript Image Cropping Engine
https://jcrop.com
Other
4.31k stars 939 forks source link

Is there any way to optimise for mobile? #35

Closed sadfuzzy closed 11 years ago

sadfuzzy commented 12 years ago

Is there any way to optimise for mobile? It works .. bad. I mean "slow" and "stucks touches all over the page". Well, the "stucks touches all over the page" i'll try to fix (not sure, but may be bootstrap bug), but "slow" is native.

tapmodo commented 12 years ago

I have a Samsung Galaxy S 4G and the Jcrop example pages work fairly acceptably to me. The iPad experience has gone down hill though. I'm confident that my "touch" code could use some improvement in regards to that. However, performance-wise, the only thing I could suggest is to try the option shade: true - not sure if that will help.

sadfuzzy commented 12 years ago

Thanks anyway!

Gladhon commented 11 years ago

On iOS devices, i have allways jumping around of the box if I try to move it...

Drag n Drop works fine if I'm using jquery.ui draggable with the jquery.ui.touch-punch.

Any suggestions what I can do?

tapmodo commented 11 years ago

The jumping has been fixed thanks to @Gladhon and the bug fix he submitted. The speed and performance issues on mobile devices are not specifically "issues" that I consider to be related to Jcrop. I'm going to close this issue since the jumping problem appears to be fixed.

sadfuzzy commented 11 years ago

Bug Fix

tapmodo commented 11 years ago

Current master branch contains a definitive fix for iOS jumping behavior and seems to improve performance. Please test!

Krunaldabhi commented 10 years ago

Don't call function of "onChange : updatePreview" ---- This is what selection area making slow.

jQuery(function($) { var cropContainer = $('#canvas'); cropContainer.Jcrop({ // onChange : updatePreview, onSelect : updatePreview, aspectRatio : 1 });