search

taptapship / wiredep

Wire Bower dependencies to your source code.
MIT License
1.15k stars 142 forks source link

Exposed detectable file type via option #136

Closed juriejan closed 9 years ago

juriejan commented 9 years ago

Not sure if there might be some kind of reason for not exposing this, but all tests seem to pass with extra file types defined. This requirement was also mentioned in #131.

stephenplusplus commented 9 years ago

Thank you for the PR. I don't fully understand this, though. I see detectableFileTypes is added as an option, but where in the code is that option being used?

I addressed the idea for reporting back all main files in the other issue:

If you just need the main files from bower components, there are other tools that will do that, such as https://github.com/ck86/main-bower-files. I think wiredep should stay focused on just injecting file references to source files.

Hope I'm not misunderstanding the idea. Thanks again!

juriejan commented 9 years ago

That bit of code seems to have been all that was required to implement the desired behaviour. I'm now using my branch to automatically copy over all the required font files from my bower packages.

I'm fine with using main-bower-files if you think that this behaviour is out of scope for this library.

Thanks for pointing me to the main-bower-files library. It might be a good idea to mention it in the README. I can imagine many people that impressed with wiredep will want to make use of it. Let me know if you'd like me to add the mention.