search

taptapship / wiredep

Wire Bower dependencies to your source code.
MIT License
1.15k stars 142 forks source link

not reading relative path correctly? #159

Closed JaKXz closed 9 years ago

JaKXz commented 9 years ago

Font Awesome's bower.json defines their main files like this:

...
  "main": [
    "./css/font-awesome.css",
    "./fonts/*"
  ],
...

However, the css file is not put in to my html files when I call wiredep as normal. So, what I have to do to make it work is have overrides that use the "less explicit"? relative path, like so:

  "overrides": {
    "font-awesome": {
      "main": ["css/font-awesome.css", "fonts/*"]
    }
  }

which makes the wiredep task work correctly. I'm not sure why these two are handled differently, because from the folder bower_components/font-awesome/ they mean the same thing. Thoughts?

stephenplusplus commented 9 years ago

Hmm, I'm not sure either. I was able to get it working: https://github.com/stephenplusplus/wiredep-159

It writes the correct path to index.html

JaKXz commented 9 years ago

Strange. I thought could swear I was seeing the issue with the gulp task, but it seems fine now. Sorry for the noise!

JaKXz commented 9 years ago

So, @stephenplusplus it looks like I had font-awesome in my devDependencies, which is why they weren't wired to my html files. That sounds like correct behaviour right?

stephenplusplus commented 9 years ago

Yes! devDependencies are ignored from being included alongside your dependencies, however, it is possible to overrule this behavior by setting devDependencies: true.

JaKXz commented 9 years ago

Excellent, thank you. Again, apologies for not paying closer attention.