search

taqueci / redmine_wysiwyg_editor

Redmine WYSIWYG Editor plugin
GNU General Public License v2.0
114 stars 27 forks source link

copy pasting from clipboard with chromium #139

Closed maudov closed 2 years ago

maudov commented 2 years ago

Hello, Copy pasting from clipboard with chromium (95.0.4) does not work. the DataTransferItemList object does not behave the same way between navigators and the copy paste function is broken.

When using chromium, DataTransferItemList contains 18 elements. image

and Firefox contains 1 element. image

mathieu-mbru commented 2 years ago

https://github.com/taqueci/redmine_wysiwyg_editor/pull/140

taqueci commented 2 years ago

This comment is just note to self.

The issue is not reproduced in my environment:

Need more investigation.

Screenshot from 2022-01-22 10-55-51 Screenshot from 2022-01-22 10-57-37

taqueci commented 2 years ago 
Environment:
  Redmine version                4.2.3.stable
  Ruby version                   2.7.4-p191 (2021-07-07) [x86_64-linux-musl]
  Rails version                  5.2.6
  Environment                    production
  Database adapter               PostgreSQL
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
SCM:
  Subversion                     1.14.1
  Mercurial                      5.5.2
  Git                            2.30.2
  Filesystem                     
Redmine plugins:
  redmine_base_deface            1.5.3
  redmine_comments               0.0.2
  redmine_wysiwyg_editor         0.23.0
taqueci commented 2 years ago

The issue can not be reproduced on:

taqueci commented 2 years ago

Hi @maudov

Can you please tell me:

maudov commented 2 years ago

Hi @taqueci, I wasn't able to reproduce the issue with the last google chrome update (early january). I had to install an older chrome version to reproduce it.

Since Chrome fixed this I will close this issue. sorry for the inconvience

maudov commented 2 years ago

Hi @taqueci, There is a similar issue reported on redmine core for older chrome version (https://www.redmine.org/issues/36013). They fixed the issue on the core so maybe it would make sense to fix it on redmine_wysiwyg. What do you think?

thx

mathieu-mbru commented 2 years ago

Hello we propose PR (https://github.com/taqueci/redmine_wysiwyg_editor/pull/151) Thank you for considering this PR.

taqueci commented 2 years ago

Hi @mathieu-mbru

Thank you for your pull request!