taqueci / redmine_wysiwyg_editor

Redmine WYSIWYG Editor plugin
GNU General Public License v2.0
114 stars 27 forks source link

Upload function targets the first inputfile of the page #144

Closed mathieu-mbru closed 2 years ago

mathieu-mbru commented 2 years ago

Hello, The upload function targets the first file input of the page and may conflict with other plugins. On our redmine instance we use the redmine_comments plugin (https://github.com/jbbarth/redmine_comments) that adds the ability to write private note and create a new form. We experienced a bug with the redmine_wysiwyg_editor targeting the wrong form. image We managed to fix this issue, by adding an inputFile property that target the closest form instead of the first input file. Here is proposition for this issues. https://github.com/taqueci/redmine_wysiwyg_editor/pull/143

taqueci commented 2 years ago

Hi @mathieu-mbru

I can't create the environment that Redmine Comments plugin works correctly. Can you please your Redmine environment information?

mathieu-mbru commented 2 years ago

Hello Info plugins comments

Thankyou

mathieu-mbru commented 2 years ago

Hello we propose another PR (https://github.com/taqueci/redmine_wysiwyg_editor/pull/150) which is simpler than (https://github.com/taqueci/redmine_wysiwyg_editor/pull/143) Thank you for considering this PR.

taqueci commented 2 years ago

Hi @mathieu-mbru

Thank you for your pull request!