taragnor / city-of-mist

City of Mist system for Foundry VTT
14 stars 20 forks source link

Spanish Translation #61

Open Yurian00 opened 6 months ago

Yurian00 commented 6 months ago

Hi Taragnor:

First of all thank you very much for your amazing work here creating this System for Foundry :-).

I'm interested on translate the system to Spanish to have it available on Foundry so that is the reason I'm using this issue to contact you. My expertise on Foundry is really basic so I can't edit code per se being confident enough to don't screw the whole thing but if you can provide me the texts that need to be translated or tell me which parts of the code need to be I will be pleasure to to it and send it back to you to add Spanish as available language for your system.

Anyways thank you in advance and I hope we can collaborate on this matter.

Best regards,

Yurian.

taragnor commented 6 months ago

Sure I'd love to add in a Spanish translation if you'd be willing to make one.

Doing translations in Foundry VTT is pretty easy. You'll only need to work on a single file, which would be called es.json and go in the lang folder.

As a template for what needs to be translated: here's the example of English and German localizations.

Here's the file in English: https://github.com/taragnor/city-of-mist/blob/main/src/city-of-mist/lang/en.json

This is the German localization file: https://github.com/taragnor/city-of-mist/blob/main/src/city-of-mist/lang/de.json

Just follow that same pattern, putting the Spanish Translations on the right hand side. It shouldn't require any coding experience, just copy the format used by the other localizations.

You can send me the file through a github pull request, and I can link it to the rest of the project.

Let me know if you have any questions.

Yurian00 commented 6 months ago

Pretty clear. I did not dig enought to check that there was a json with the lanaguages so it is pretty easy. I'll be back as soon as I have it translated.

Thank you very much for your help.

Yurian00 commented 6 months ago

There are a little diferences on the code side in the json at least in the first lines. I assume it is better if I use the English json as base for the tranlation, right? imagen_2024-04-13_005419071 imagen_2024-04-13_005448766

taragnor commented 6 months ago

Yeah not all the translation files are entirely up to date except for English version. I added quite a few new translation keys and the other translators haven't quite caught up (translations usually are a few versions behind).

So use the translation keys (the period-separated names on the left hand side) from the en.json for the best results.

Thanks.

Yurian00 commented 6 months ago

Nice. I've advance over that file but I see that Oherscape and LitM are there too and I'm not familiarized with them yet so that translation will be more a "guessing" XD.

Additionaly I've detected that with more than 2 spectrums in dangers those overlap with the tabs (movement/tags, themes, bio) as you can see here. imagen_2024-04-18_175346426

Yurian00 commented 6 months ago

It only happens during the edition of the character sheet. As soon as you close it, it looks ok so it is a minor issue.