search

tarak / django-password-policies

Django unicode-aware password policies.
Other
59 stars 92 forks source link

hopefully fixes https://github.com/tarak/django-password-policies/issues... #2

Closed starenka closed 11 years ago

starenka commented 11 years ago

.../1

(sorry for issue AND pull request, but I was lazy to fix this at first, but realized it's a cakewalk (hopefully) later)

tarak commented 11 years ago

No problem about opening an issue and a pull request. Did you run the tests (see http://tarak.github.io/django-password-policies/topics/testing.html)? I'm using Django 1.6 and just found out that there's a new issue. Could you please check that for me?

starenka commented 11 years ago

Well, to spread even more havoc, I found out i haven't fixed all problems in this pull request. This commit https://github.com/starenka/django-password-policies/commit/d9e653ee2a65d9f2da95151d58fa1da5b7ffec11 passes and seems to solve the issue on 1.5.2. Should I run it against trunk, too?

(Can you - if you going to merge that commit - please destroy the previous pull request and this issue?)

tarak commented 11 years ago

I guess it would fail... See #3. I had a feeling and you proved I was right. Thanks. I'll merge your pull request.

starenka commented 11 years ago

Hehe, but the real working patch is this commit https://github.com/starenka/django-password-policies/commit/d9e653ee2a65d9f2da95151d58fa1da5b7ffec11 as i wrote in my previous comment :( (fixes comparing in three files, not just one)

tarak commented 11 years ago

I know... Hehehe... Just commented https://github.com/starenka/django-password-policies/commit/d9e653ee2a65d9f2da95151d58fa1da5b7ffec11 - you still need to open another pull request.

tarak commented 11 years ago

I wanted to say that sometimes I click some buttons to soon. Maybe like you opening an issue and and a request. We're just humans after all... :-)

starenka commented 11 years ago

;)