guard against ideal entropy being zero. Fixes: #22

tarak / django-password-policies

Django unicode-aware password policies.

Other

59 stars 92 forks source link

Closed kouk closed 10 years ago

tpeaton commented 10 years ago

Drama ensues! #21 :smile:

tarak commented 10 years ago

Do you mind writing some tests?

tpeaton commented 10 years ago

@tarak, i've got a test case that covers this in #21 . Running the new test without the other commits will expose the error.

kouk commented 10 years ago

Ooops, and i thought i looked through the issue list before submitting my fix😊

tpeaton commented 10 years ago

I was a bad citizen and didn't open an issue before I created my PR.

kouk commented 10 years ago

oh you!

tarak commented 10 years ago

ok, can you guys decide wich PR to merge? Should I merge both?

kouk commented 10 years ago

I think @tpeaton's fix is equivalent to mine but perhaps more explicit as to what and why it is like it is. So feel free to merge his PR.

tpeaton commented 10 years ago

Thanks @kouk, classy move.