fixes errors on Python 3

tarak / django-password-policies

Django unicode-aware password policies.

Other

59 stars 92 forks source link

fixes errors on Python 3 #37

Closed nesaro closed 9 years ago

nesaro commented 9 years ago

Changes Exception catching syntax implements a fake smart_unicode function if it is not available.

landscape-bot commented 9 years ago

Repository health decreased by 0.08% when pulling 139ceed on FundingOptions:master into fb7ac2a on tarak:master.

2 new problems were found (including 0 errors and 0 code smells).
No problems were fixed.

tarak commented 9 years ago

Can you please take a look at the Travis CI build errors, pep8 complains about syntax:

password_policies/forms/validators.py:12:5: E731 do not assign a lambda expression, use a def
password_policies/forms/validators.py:12:29: E231 missing whitespace after ':'

I'll gladly merge when fixed. Do you use this on Python 3? If so would it be possible for you to extend the .travis.yml file to include testing on Python 3?

nesaro commented 9 years ago

Sure, I'll fix both errors. At the moment I'm only using the validators file so I don't know if there is any issue on porting the rest code to python 3.4, but I'll have a look.

landscape-bot commented 9 years ago

Repository health decreased by 0.03% when pulling df4d671 on FundingOptions:master into fb7ac2a on tarak:master.

1 new problem was found (including 0 errors and 0 code smells).
No problems were fixed.

landscape-bot commented 9 years ago

Code quality remained the same when pulling 0c96dd7 on FundingOptions:master into fb7ac2a on tarak:master.

tarak commented 9 years ago

I'm closing this PR as the newer PR #39 should solve your issue. Feel free to reopen if you think I'm wrong.