Broken in Django 1.10

[djangoat]

Changes in Django 1.10 means MIDDLEWARE_CLASSES now becomes MIDDLEWARE.

password_policies.middleware.PasswordChangeMiddleware now broken:

in load_middleware
    mw_instance = middleware(handler)
TypeError: object() takes no parameters

https://docs.djangoproject.com/en/1.10/topics/http/middleware/#upgrading-pre-django-1-10-style-middleware

All it seems to need is:

from django.utils.deprecation import MiddlewareMixin

class PasswordChangeMiddleware(MiddlewareMixin):

Tested, and seems fine.

[tarak]

See PR #59 comments...

[mpasternak]

Hey @tarak, I love your app, any chances of supporting Django 1.10 soon? Thanks!

[abarresi-abamis]

Any plans to merge pull request https://github.com/tarak/django-password-policies/pull/63 to address this issue?

[aboudreault]

What's up here @tarak ? We are looking to migrate to 1.11...

[lorddaedra]

I suggest to update package and follow https://www.djangoproject.com/download/

Supported Django versions: Django 1.8 LTS, 1.10, 1.11 LTS. For now looks like this package is broken in 66,67% of supported configurations...

[mpasternak]

There's pull request for that. @tarak , if you're no longer interested in maintaining the package perhaps it would be wise to consider passing the maintainership to someone... unless someone forks it

[mpasternak]

Just to let you know, I've e-mailed @tarak and asked him to give me commit privs to the repo and to the PyPI package, I'm willing to maintain it.

[DanEEStar]

@mpasternak @tarak What is the status of this?

[mpasternak]

I’ve received no reply at all.

[mpasternak]

Django 2.0 requires on_delete argument to ForeignKeys, so I guess I'm going to prepare a fix in my branch.

EDIT: here you go https://github.com/tarak/django-password-policies/pull/64

[aboudreault]

This project is dead guys, @tarak is just not professional enough to mention us he doesn't want to work on it anymore and too lazy to give the maintainer role to someone else. Seriously, just fork this project and we will all adopt it.

[mpasternak]

Hi,

I have forked the project and I continue the work in my fork: https://github.com/iplweb/django-password-policies-iplweb

Feel free to report any issues, patches, docs improvements also badly needed.

I'm using this in a commercial project so I guess I'll maintain my fork for a few years at least.