search

tarampampam / error-pages

🚧 Pretty server's error pages in the docker image & git repository (for traefik, k8s, nginx and so on)
https://tarampampam.github.io/error-pages/
MIT License
802 stars 78 forks source link

ADD_TEMPLATE env var #294

Closed JohnLindahlTech closed 3 weeks ago

JohnLindahlTech commented 3 weeks ago

Is there an existing issue for this?

Describe the problem to be solved

Trying out v3 in docker with tarampampam/error-pages:3.1.0

I have always been running a custom template and with the new version I need to run the cli flag --add-template and it makes the Docker-composefile a bit messy which was not needed prior.

Suggest a solution

Adding a companion env var ADD_TEMPLATE as for the other config flags, would allow me to not override the default command in docker.

Additional context

No response

tarampampam commented 3 weeks ago

May I ask if there are any problems with the command overriding? Setting it to serve --add-template /path/to/file shouldn't be difficult, I suppose. Or am I mistaken?

JohnLindahlTech commented 3 weeks ago

Not difficult, more on the keeping things neat as I prefer config via env-vars. For visuals and easier to maintain I find it.

tarampampam commented 3 weeks ago

🚀 v3.2.0

JohnLindahlTech commented 3 weeks ago

Thank you very much!