search

taraniselsu / TacLifeSupport

Life Support from Thunder Aerospace Corporation
Other
76 stars 61 forks source link

1.1 support (WIP) #90

Open cherrydev opened 8 years ago

cherrydev commented 8 years ago

I've given this a quick run-through and it looks like with the new assemblies and the API changes listed here the mod properly loads and at least appears to do the basic job of tracking resources! I'll probably work on this some more to make sure the rest works (i'm not sure if I have the GUI stuff working properly). It might be good to go, though. I'll make a PR when I've worked on it more.

taraniselsu commented 8 years ago

Hey, sorry I did not respond earlier. I've been really busy.

How far did you get? Would you share it, even if it is in an incomplete state? The people involved with Realism Overhaul might also be able to contribute some: https://github.com/KSP-RO/RealismOverhaul/issues/1120.

Thanks!

cherrydev commented 8 years ago

Did you see the post on the thread I just made a little while ago? How about if I just make you a pull request that contains only the changes to the .cs files and you can update the rest of your build scripts to link against the new libraries? I'm using a regular Visual Studio setup to do my mod building so I pretty much had to scrap all of your tooling files and start over in order to get it to build on my machine, so I assume you're not interested in those files but just want the updated source code, right?

taraniselsu commented 8 years ago

Anything that you can share that helps get this working in 1.1 would be great.

I am curious what problems you encountered that led to "so I pretty much had to scrap all of your tooling files and start over". I assume you are on Windows since you mentioned VS. I also assume that you don't have the MSBuild.ExtensionPack, which I have already worked to remove, but in my experience it did not prevent building. The other thing I can think of is: do you have the git installed and available from the command line? Oh, also I was using grep. I should add some error checking so that those don't stop the project from building. It should just not automatically fill in the version number.

cherrydev commented 8 years ago

I sent you a link to what I have in a PM on the forum.

taraniselsu commented 8 years ago

Would you share it here? I won't have a chance to look at it until the end of the month :(.

james3838 commented 8 years ago

Had some time, so did the basic changes to get the mod "working". Icon is not working, probably same issue that @cherrydev mention. Verified sending rocket to orbit that resources consumed/updated based on modules used.