taraniselsu / TacPartLister

Part Lister from Thunder Aerospace.
Other
4 stars 1 forks source link

fixed the issue #13 "Turning off a column disables the total at the bottom" and added GUI improvements. Also some code was reworked to implement taraniselsu's idea to split data processing and GUI #15

Closed girka2k closed 9 years ago

girka2k commented 10 years ago

Fixed the issue #13 "Turning off a column disables the total at the bottom" and fixes version number

Added some GUI Improvements:

2014-11-14 00-06-20 kerbal space program

2014-11-14 00-17-49 kerbal space program

2014-11-14 00-18-30 kerbal space program

2014-11-14 00-19-08 kerbal space program

taraniselsu commented 10 years ago

It looks like this includes the changes from #14.

taraniselsu commented 10 years ago

Thank you for doing this. I like your ideas, especially the coloration.

I have an idea for how I would like to fix issue #13, even though it requires significant rework of the code, and it might significantly improve performance when building larger vessels.

The idea is:

That should reduce the number of times that we loop through the entire vessel and should reduce the number of times that things like wet/dry/resource masses and costs are calculated. The totals could also be cached.

Is that something you would be interested in doing?

girka2k commented 10 years ago

Seems for me that it is good idea! If you don't mind, I'll try to offer my implementation of your idea. However, I don't have the slightest idea how events are implemented in KSP :(. So If you are comfortable with this and you don't have time to do it right now - I would be delighted if you would trust me to try to do two procedures - one (draft) for calculating mass and other stuffs and other - reworked DrawWindowContents. I hope you know how to handle events in KSP :). I will be glad to learn it from you.

taraniselsu commented 10 years ago

I would appreciate your help. As I said, I've liked the changes you have done so far. Also, I don't have much time to work on this, especially with the upcoming holidays.

Here is an example of how to use GameEvents: Register for the event Unregister Handle the event

List of events. All of the on* methods. I have not looked through the list so I do not know which you will need yet.

girka2k commented 10 years ago

Taraniselsu, thanks for the examples of event handling! Everything was much easier than I thought. I implemented your idea, how I could. I would be grateful if you will take the time to review the proposed changes and to provide your comments.