tarantool / cbench

Tarantool C Bench - a simple tool to benchmark Tarantool internal API
BSD 2-Clause "Simplified" License
4 stars 2 forks source link

error: remove failing code from microb integration #6

Closed koshoi closed 3 years ago

koshoi commented 3 years ago

In commit 51836e1fa6d5e040306bbe67ca28525450c8a863 the code responsible for microb integration was removed, but not completely. This remainings caused benchmark to exit with non-zero exit code, which is not good for automation. The other unused code was also removed. I also added .luacheckrc config that could have spotted the error before.

avtikhon commented 3 years ago

Patch LGTM.

Totktonada commented 3 years ago

I looked again at the code (quite briefly) and I have no any objections anymore. Didn't test it.