tarantool / checkpatch

Checkpatch for Tarantool
GNU General Public License v2.0
2 stars 2 forks source link

False-positive error for C++: Spaces needed around that '&' #13

Closed locker closed 2 years ago

locker commented 2 years ago

https://github.com/tarantool/tarantool/commit/12bcf7e35b79fc0cd272b15552a321e633f1b445

$ ../checkpatch/checkpatch.pl -g 12bcf7e35b79fc0cd272b15552a321e633f1b445
ERROR: spaces needed around that '&' (ctx:WxV)
#117: FILE: src/lib/core/cxx_abi.cc:23:
+       DemangleBuf(DemangleBuf &other) = delete;
                                ^

ERROR: spaces needed around that '&' (ctx:WxV)
#119: FILE: src/lib/core/cxx_abi.cc:25:
+       DemangleBuf &operator=(DemangleBuf &other) = delete;
                    ^

ERROR: spaces required around that '=' (ctx:VxV)
#119: FILE: src/lib/core/cxx_abi.cc:25:
+       DemangleBuf &operator=(DemangleBuf &other) = delete;
                             ^

ERROR: spaces needed around that '&' (ctx:WxV)
#119: FILE: src/lib/core/cxx_abi.cc:25:
+       DemangleBuf &operator=(DemangleBuf &other) = delete;
                                           ^

ERROR: spaces needed around that '&' (ctx:WxV)
#121: FILE: src/lib/core/cxx_abi.cc:27:
+       static DemangleBuf &instance()
                           ^

total: 5 errors, 137 lines checked

Commit 12bcf7e35b79 ("core: refactor C++ ABI usage") has style problems, please review.

NOTE: If any of the errors are false positives, please file a bug at
      https://github.com/tarantool/checkpatch/issues