tarantool / checkpatch

Checkpatch for Tarantool
GNU General Public License v2.0
2 stars 2 forks source link

False positive "definition without comment" #2

Closed sergepetrenko closed 2 years ago

sergepetrenko commented 2 years ago

Example: https://github.com/tarantool/tarantool/runs/5507926313?check_suite_focus=true#step:3:136

ERROR: 'raft_update' definition without comment
FILE: src/lib/raft/raft.c:822:
+raft_update(struct raft *raft)

While src/lib/raft/raft.c has the following:

 271 /**                                                                              
 272  * Check the conditions for starting elections, and start them, if possible.     
 273  * These conditions are:                                                         
 274  * - no connection to the old leader                                             
 275  * - a quorum of connected peers                                                 
 276  * - none of the peers sees the old leader                                       
 277  */                                                                              
 278 static void                                                                      
 279 raft_update(struct raft *raft);

and later the line which triggers checkpatch:

 821 static void                                                                      
 822 raft_update(struct raft *raft)                                                       
 823 {