tarantool / checkpatch

Checkpatch for Tarantool
GNU General Public License v2.0
2 stars 2 forks source link

A patch file can legally have a trailing whitespace #25

Closed Totktonada closed 2 years ago

Totktonada commented 2 years ago

However the checkpatch script compains about it. Example: https://github.com/tarantool/tarantool/commit/157b446499375ab3ee80f2878d344dcd1c701a31.

The file:

diff -ru a/test/v3ext.c b/test/v3ext.c
--- a/test/v3ext.c  2022-07-05 12:08:33.000000000 +0300
+++ b/test/v3ext.c  2022-07-14 21:07:10.586081541 +0300
@@ -8,6 +8,7 @@
  */

 #include <stdio.h>
+#include <string.h>
 #include <openssl/x509.h>
 #include <openssl/x509v3.h>
 #include <openssl/pem.h>

The script output:

$ ~/p/t/checkpatch/checkpatch.pl --color=always --git HEAD~1..HEAD
ERROR: trailing whitespace
#79: FILE: static-build/openssl-111q-gh-18720.patch:6:
+ $

total: 1 errors, 41 lines checked

Commit 157b44649937 ("static-build: bump openssl from 1.1.1n to 1.1.1q") has style problems, please review.

NOTE: If any of the errors are false positives, please file a bug at
      https://github.com/tarantool/checkpatch/issues

I can propose the following solutions: