Closed sergepetrenko closed 2 years ago
Checkpatch fails with the following error:
Commit 6c2d50ed1b29 ("core: replace trigger initializers with trigger_create() calls") -------------------------------------------------------------------------------------- ERROR:UNCOMMENTED_DEFINITION: 'vy_set_deferred_delete_trigger' definition without comment #247: FILE: src/box/vinyl.c:4564: +vy_set_deferred_delete_trigger(void) total: 1 errors, 228 lines checked Commit 6c2d50ed1b29 ("core: replace trigger initializers with trigger_create() calls") has style problems, please review.
However there's a comment right next to function declaration. I just didn't move it with the definition to avoid extra unnecessary changes: https://github.com/tarantool/tarantool/commit/6c2d50ed1b297c53408c3749dabc4f24ba04ae16#diff-e2a70067112560854fbbbf0ea7ad98a6199600109cdd075f74f865c03c374d35L2838-R2841
I guess this is a leftover from the time when #2 was fixed. The comment is untouched, and probably is missed due to this, but it still can be seen in one of the diff hunks.
Checkpatch fails with the following error:
However there's a comment right next to function declaration. I just didn't move it with the definition to avoid extra unnecessary changes: https://github.com/tarantool/tarantool/commit/6c2d50ed1b297c53408c3749dabc4f24ba04ae16#diff-e2a70067112560854fbbbf0ea7ad98a6199600109cdd075f74f865c03c374d35L2838-R2841
I guess this is a leftover from the time when #2 was fixed. The comment is untouched, and probably is missed due to this, but it still can be seen in one of the diff hunks.