tarantool / checkpatch

Checkpatch for Tarantool
GNU General Public License v2.0
2 stars 2 forks source link

Check patch complains about deletions in .result file (again) #38

Closed sergepetrenko closed 2 years ago

sergepetrenko commented 2 years ago

I have checkpatch checked out locally at commit

commit 418505c89ce5866fc9697a52e0df832b3b35fafb
Author: Sergey Bronnikov <sergeyb@tarantool.org>
Date:   Mon Sep 5 19:13:44 2022 +0300

    Allow updating .result files

And still the issue persists. Old checkpatch complained about 3 of my commits, because they changed test/unit/*.result And new checkpatch complains about one commit, which has deletions in test/box-py/iproto.result, it seems:

-----------------------------------------------------------------
Commit 98691a9d825b ("core: introduce linearizable transactions")
-----------------------------------------------------------------
ERROR: Please avoid new tests with .result files

total: 1 errors, 1346 lines checked
Commit 98691a9d825b ("core: introduce linearizable transactions") has style problems, please review.

git show 98691a9d825b -- *.result output :

diff --git a/test/box-py/iproto.result b/test/box-py/iproto.result
index ea32f8bc8..70e37ae57 100644
--- a/test/box-py/iproto.result
+++ b/test/box-py/iproto.result
@@ -129,18 +129,12 @@ space2 = box.schema.create_space('test2')
 ...
 Schema changed -> error: True
 Got another schema_id: True
-Sync ok
-Sync on error is ok
 space:drop()
 ---
 ...
 space2:drop()
 ---
 ...
-box.space._cluster:delete{2} ~= nil
----
-- true
-...
 space = box.schema.create_space('gh1280', { engine = 'vinyl' })
 ---
 ...