If I add a comment to the first function, then all is fine. But the second function remains without a comment. So either the error was false-positive, or on_commit_dd_version() ignorance was false-negative. Or is there some hidden rule like how many lines can a function have without needing a comment?
Checkpatch doesn't require comments to short functions. A function is considered short if its body is <= 3 lines, not counting lines like assert(foo); and (void)foo;.
I have the following 2 new functions in a patch:
Checkpatch complains only about the first one:
If I add a comment to the first function, then all is fine. But the second function remains without a comment. So either the error was false-positive, or
on_commit_dd_version()
ignorance was false-negative. Or is there some hidden rule like how many lines can a function have without needing a comment?