search

tarantool / checkpatch

Checkpatch for Tarantool
GNU General Public License v2.0
2 stars 2 forks source link

'od' (abbreviated 'ordered dictionary') is considered as misspelled 'of' in Lua code #70

Closed Totktonada closed 6 months ago

Totktonada commented 6 months ago

The warning looks valid in the general case, but my commit adds an ordered dictionary implementation and od is used in many places as a variable name in Lua code. There are also several usages in comments (in usage examples, which are Lua code as well).

It would be nice if I can mark a word as a known exception for the spelling check using the commit message.

Also, it seems, it depends on a spelling dictionary. I use --codespell --codespellfile /usr/lib/python3.10/site-packages/codespell_lib/data/dictionary.txt locally and it doesn't warn me. However, tarantool's CI complains. It uses apt install -y codespell on Ubuntu Focal and passes just --codespell to the checkpatch.pl invocation.

Totktonada commented 6 months ago

NB: It was removed from a newer versions of codespell.