search

tarantool / docker

Docker images for tarantool database
https://hub.docker.com/r/tarantool/tarantool
52 stars 25 forks source link

Fix luarocks installation functionality #177

Closed avtikhon closed 4 years ago

avtikhon commented 4 years ago

Alpine 3.5/3.9 had internal wget tool based on it's busybox. Found that it was not workable with luacheck tool. The current fix changes wget tool from busybox to wget from package. To install wget from the package added git package installation. Also repository update added.

Closes #170

LeonidVas commented 4 years ago

Hi! Thank you for the patch. Seems like it could be split into two commits for alpine 3.5 and 3.9. Also, please specify the smallest wget version.

avtikhon commented 4 years ago

Thanks, for the review, please check my questions below:

Hi! Thank you for the patch. Seems like it could be split into two commits for alpine 3.5 and 3.9.

That ok, I'll do it.

Also, please specify the smallest wget version.

As was written in research of the currently fixing issue #170 alpine 3.5-3.9 versions don't have workable with luacheck wget tool. The current fix changes wget from busybox to standalone wget from package:

# ls -al `which wget`
lrwxrwxrwx    1 root     root            12 Jul 31 15:50 /usr/bin/wget -> /bin/busybox

# apk add wget
(1/1) Installing wget (1.20.3-r0)
Executing busybox-1.29.3-r10.trigger
OK: 251 MiB in 69 packages

# ls -al `which wget`
-rwxr-xr-x    1 root     root        449888 Apr  8  2019 /usr/bin/wget
LeonidVas commented 4 years ago

As was written in research of the currently fixing issue #170 alpine 3.5-3.9 versions don't have workable with luacheck wget tool. The current fix changes wget from busybox to standalone wget from package:

Can you specify the min. wget version in the commit message? I think this is useful knowledge.

LeonidVas commented 4 years ago

That ok, I'll do it.

Ok.

LeonidVas commented 4 years ago

As was written in research of the currently fixing issue #170 alpine 3.5-3.9 versions don't have workable with luacheck wget tool. The current fix changes wget from busybox to standalone wget from package:

Can you specify the min. wget version in the commit message? I think this is useful knowledge.

From https://www.opennet.ru/man.shtml?topic=busybox

wget
wget [-c|--continue] [-q|--quiet] [-O|--output-document file]         [--header 'header: value'] [-P DIR] url
wget retrieves files via HTTP or FTP

Options:

        -c      continue retrieval of aborted transfers
        -q      quiet mode - do not print
        -P      Set directory prefix to DIR
        -O      save to filename ('-' for stdout)