Closed DerekBum closed 7 months ago
Please, update the commit message: add GreetingDialer too.
Please, update the commit message: add GreetingDialer too.
It is in the commit message:
GreetingDialer
is created to fill theGreeting
in the created connection.
Please, update the commit message: add GreetingDialer too.
It is in the commit message:
GreetingDialer
is created to fill theGreeting
in the created connection.
But the title is confusing. It could be something like: api: add helper Dialer implementation
or something like that.
Please, update the commit message: add GreetingDialer too.
It is in the commit message:
GreetingDialer
is created to fill theGreeting
in the created connection.But the title is confusing. It could be something like:
api: add helper Dialer implementation
or something like that.
Oh, I thought you were talking about commit body, not header. Updated commit header and PR header too.
To disable SSL by default we want to transfer
OpenSslDialer
to the go-openssl repository. In order to do so, we need to minimize the amount of copy-paste of the private functions.AuthDialer
is created as a dialer-wrapper, that calls authentication methods.ProtoDialer
is created to check theProtocolInfo
in the created connection.GreetingDialer
is created to fill theGreeting
in the created connection.I didn't forget about (remove if it is not applicable):
Related issues: Part of #301