tarantool / go-tarantool

Tarantool 1.10+ client for Go language
https://pkg.go.dev/github.com/tarantool/go-tarantool/v2
BSD 2-Clause "Simplified" License
180 stars 57 forks source link

api: add helper Dialer implementations #371

Closed DerekBum closed 7 months ago

DerekBum commented 7 months ago

To disable SSL by default we want to transfer OpenSslDialer to the go-openssl repository. In order to do so, we need to minimize the amount of copy-paste of the private functions.

AuthDialer is created as a dialer-wrapper, that calls authentication methods. ProtoDialer is created to check the ProtocolInfo in the created connection. GreetingDialer is created to fill the Greeting in the created connection.

I didn't forget about (remove if it is not applicable):

Related issues: Part of #301

oleg-jukovec commented 7 months ago

Please, update the commit message: add GreetingDialer too.

DerekBum commented 7 months ago

Please, update the commit message: add GreetingDialer too.

It is in the commit message:

GreetingDialer is created to fill the Greeting in the created connection.

oleg-jukovec commented 7 months ago

Please, update the commit message: add GreetingDialer too.

It is in the commit message:

GreetingDialer is created to fill the Greeting in the created connection.

But the title is confusing. It could be something like: api: add helper Dialer implementation or something like that.

DerekBum commented 7 months ago

Please, update the commit message: add GreetingDialer too.

It is in the commit message:

GreetingDialer is created to fill the Greeting in the created connection.

But the title is confusing. It could be something like: api: add helper Dialer implementation or something like that.

Oh, I thought you were talking about commit body, not header. Updated commit header and PR header too.