search

tarantool / go-tarantool

Tarantool 1.10+ client for Go language
https://pkg.go.dev/github.com/tarantool/go-tarantool/v2
BSD 2-Clause "Simplified" License
180 stars 57 forks source link

api: remove ssl #379

Closed DerekBum closed 7 months ago

DerekBum commented 7 months ago

OpenSslDialer and all of its helper functions and tests were rellocated to the go-tlsdialer [1] package (and renamed to OpenSSLDialer). So now we can safely remove all the copy-pasted code from go-tarantool.

This way, in order to use SSL, user should import the go-tlsdialer package and call functions from there.

After all Tarantool-EE specific logic was moved to the go-tlsdialer, Tarantool-EE jobs could be removed from ci workflows. In a separate commit, Tarantool-EE jobs are removed from the ci workflows.

  1. https://github.com/tarantool/go-tlsdialer/

Related issues:

Closes #301

oleg-jukovec commented 7 months ago

In the commit message:

s/[1] https://github.com/tarantool/go-tlsdialer/1. https://github.com/tarantool/go-tlsdialer/

The commit message should be < 72 characters. Now it is too short at the first glance.

oleg-jukovec commented 7 months ago

Please, s/OpenSsl/OpenSSL/g

DerekBum commented 7 months ago

Please, s/OpenSsl/OpenSSL/g

That was already changed this morning.