search

tarantool / graphql

GraphQL implementation in Lua
MIT License
15 stars 3 forks source link

Add init.lua to rockspec #46

Closed no1seman closed 2 years ago

no1seman commented 2 years ago

Add lost init.lua to rockspec

Totktonada commented 2 years ago

Thank for pinging me. I'm aware of this pull request, but in fact we should reimplement the solution of the graphql.VERSION constant generation (see #29 and PR #41).

  1. tarantoolctl rocks pack checked out sources from the git tag. So the modified init.lua does not land into the .src.rock file.
  2. It does not work by construction for installing from the rockspec (without .src.rock).

The .src.rock for the 0.1.3 release was repacked manually (unzip, fix, zip).

I see the only solution: move from the builtin build type to make and call git describe --long --always inside the build phase.

no1seman commented 2 years ago

@Totktonada Let's move to Cmake buildtype and pack all.rock instead src.rock?

no1seman commented 2 years ago

closing this PR in favour of https://github.com/tarantool/graphql/pull/50